Addressed static code analysis warnings #225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic0ns
commented
Jun 12, 2025
Contributor
Author
There was a problem hiding this comment.
can we move it? does it need to be in the main folder? whats a good position for it?
| public void setXor(byte[] xor) { | ||
| this.xor = xor; | ||
| this.xor = xor == null ? null : xor.clone(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
These changes need to be reverted - we dont want them
Comment on lines
+41
to
+43
| @SuppressWarnings("unused") | ||
| public LongSwapEndianModification(LongSwapEndianModification other) { | ||
| super(); | ||
| this(); |
Contributor
Author
There was a problem hiding this comment.
why is this still here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should address or suppress all existing static code-analysis issues